| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20130302231626.GA23826@lizard.sbx05280.losalca.wayport.net> Date: Sat, 2 Mar 2013 15:16:26 -0800 From: Anton Vorontsov <anton@...msg.org> To: Pali Rohár <pali.rohar@...il.com> Cc: Samuel Ortiz <sameo@...ux.intel.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/2] mfd: twl4030-madc: Add support for raw value in twl4030_madc_conversion On Fri, Feb 15, 2013 at 11:56:49PM +0100, Pali Rohár wrote: > Driver twl4030-madc has hardcoded channel types (10 - battery current, > 1 - battery temperature) and also conversation data in variable > twl4030_divider_ratios. These hardcoded channels are incorrect for > Nokia RX-51 board (where is channel 0 - battery temperature). > > For Nokia RX-51 there is rx51_battery power_supply driver which reporting > battery information via twl4030_madc_conversion. But this driver needs > raw values (not converted via some hardcoded functions). So this patch > adding new parameter "raw" to struct twl4030_madc_request which tell > twl4030-madc driver to not convert values, but rather return raw. > > Signed-off-by: Pali Rohár <pali.rohar@...il.com> It looks good to me; glancing around, I don't see any better way to do it. So, Reviewed-by: Anton Vorontsov <anton@...msg.org> Thanks! Anton -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists