linux-kernel - Re: [PATCH] drm/i915: Fix missing variable initilization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 3 Mar 2013 18:20:26 +0100
From:	Daniel Vetter <daniel@...ll.ch>
To:	Syam Sidhardhan <syamsidhardh@...il.com>
Cc:	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
	airlied@...ux.ie, daniel.vetter@...ll.ch,
	Paulo Zanoni <przanoni@...il.com>
Subject: Re: [PATCH] drm/i915: Fix missing variable initilization

On Mon, Feb 25, 2013 at 04:05:38AM +0530, Syam Sidhardhan wrote:
> Need to initialize the variable wait to false.
> 
> Signed-off-by: Syam Sidhardhan <s.syam@...sung.com>

Looks sane, thanks for the patch. Cc'ing Paulo in case I've missed
something.
-Daniel

> ---
>  drivers/gpu/drm/i915/intel_ddi.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index fc95ef0..5d0a687 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -1391,8 +1391,8 @@ void intel_ddi_prepare_link_retrain(struct drm_encoder *encoder)
>  	struct intel_dp *intel_dp = &intel_dig_port->dp;
>  	struct drm_i915_private *dev_priv = encoder->dev->dev_private;
>  	enum port port = intel_dig_port->port;
> -	bool wait;
>  	uint32_t val;
> +	bool wait = false;
>  
>  	if (I915_READ(DP_TP_CTL(port)) & DP_TP_CTL_ENABLE) {
>  		val = I915_READ(DDI_BUF_CTL(port));
> -- 
> 1.7.9.5
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/