linux-kernel - Re: [GIT PULL] gpio changes for v3.9; second round

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 3 Mar 2013 10:50:58 -0800
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Grant Likely <grant.likely@...retlab.ca>
Cc:	Linus Walleij <linus.walleij@...aro.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] gpio changes for v3.9; second round

On Sat, Mar 2, 2013 at 6:24 AM, Grant Likely <grant.likely@...retlab.ca> wrote:
>
> 2nd round of GPIO changes for Linux 3.9
>
> This branch contains a few bug fixes that I missed the first time around
> and updates to the gpio_desc series included in the first pull request.
>
> ----------------------------------------------------------------
> Gabriel Fernandez (1):
>       gpio/stmpe: pass DT node to irqdomain

This breaks the build for me. I get

  drivers/gpio/gpio-stmpe.c: In function ‘stmpe_gpio_irq_init’:
  drivers/gpio/gpio-stmpe.c:313:23: error: ‘struct gpio_chip’ has no
member named ‘of_node’
  drivers/gpio/gpio-stmpe.c:316:61: error: ‘struct gpio_chip’ has no
member named ‘of_node’
  drivers/gpio/gpio-stmpe.c: In function ‘stmpe_gpio_probe’:
  drivers/gpio/gpio-stmpe.c:351:18: error: ‘struct gpio_chip’ has no
member named ‘of_node’

and I don't think this is a merge error.

Should this driver depend on CONFIG_OF_GPIO, or should it have
#ifdef's? Regardless, it's clearly broken right now.

Unpulled.

                Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/