linux-kernel - Re: [PATCH v2] sp5100_tco: Remove code that may cause a boot failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 03 Mar 2013 10:40:21 +0100
From:	Paul Menzel <paulepanter@...rs.sourceforge.net>
To:	Takahisa Tanaka <mc74hc00@...il.com>
Cc:	linux-watchdog@...r.kernel.org, Wim Van Sebroeck <wim@...ana.be>,
	Arkadiusz Miskiewicz <arekm@...en.pl>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jonathan Nieder <jrnieder@...il.com>,
	linux-kernel@...r.kernel.org,
	Florian Mickler <florian@...kler.org>,
	Joseph Salisbury <joseph.salisbury@...onical.com>,
	Joseph Salisbury <josephtsalisbury@...il.com>
Subject: Re: [PATCH v2] sp5100_tco: Remove code that may cause a boot failure

Dear Takahisa,


thank you for your patch.


Am Sonntag, den 03.03.2013, 14:52 +0900 schrieb Takahisa Tanaka:
> The critical problem which can't boot OS until the power is completely
> cut off found on PC with SB700 chipset.

As commented in my first reply – at least I think – please add the
mainboard model in here too.

Also add the commit (summary and hash) introducing this problem.

> This patch fix the problem, but,

• fix*es*

> this patch prevents the sp5100_tco driver from using watchdog timer
> function of chipset on PC with SP5100 or SB7x0 chipset.

I still do not understand it, as your patches were for SB8x0 support,
right?

> Re-programming the MMIO address registers for the watchdog timer must
> have generated the problem. However, I don't know root cause so far.
> So, I decided to remove the concerned codes.
> 
> Note that this patch is dependent on the commit adbdcc03 and a6e26b13.

Please add the commit summaries, as a lot of people cannot memorize
commit hashes.

Is this patch exactly reverting these two patches?

> Link: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1116835
> Link: https://lkml.org/lkml/2013/2/14/271
> 
> Signed-off-by: Takahisa Tanaka <mc74hc00@...il.com>

As Linux 3.8 has been released, please add

CC: stable@...r.kernel.org

> ---
> v1 -> v2
>  -The patch was split into the bug fix and the typo fix.

Thanks. Good idea.

> ---
>  drivers/watchdog/sp5100_tco.c | 126 ++----------------------------------------
>  1 file changed, 6 insertions(+), 120 deletions(-)

[…]


Thanks,

Paul

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)