linux-kernel - Re: [PATCH V3] spi: tegra114: add spi driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130302230906.141BE3E336A@localhost>
Date:	Sat, 02 Mar 2013 23:09:06 +0000
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Manish Badarkhe <badarkhe.manish@...il.com>,
	Laxman Dewangan <ldewangan@...dia.com>
Cc:	rob.herring@...xeda.com, broonie@...nsource.wolfsonmicro.com,
	linux-doc@...r.kernel.org, devicetree-discuss@...ts.ozlabs.org,
	linux-kernel@...r.kernel.org,
	spi-devel-general@...ts.sourceforge.net,
	linux-tegra@...r.kernel.org, swarren@...dia.com
Subject: Re: [PATCH V3] spi: tegra114: add spi driver

On Fri, 22 Feb 2013 19:59:11 +0530, Manish Badarkhe <badarkhe.manish@...il.com> wrote:
> On Fri, Feb 22, 2013 at 6:07 PM, Laxman Dewangan <ldewangan@...dia.com> wrote:
> > Add SPI driver for NVIDIA's Tegra114 SPI controller. This controller
> > is different than the older SoCs SPI controller in internal design as
> > well as register interface.
> >
> > This driver supports the:
> > - non DMA based transfer for smaller transfer i.e. less than FIFO depth.
> > - APB DMA based transfer for lager transfer i.e. more than FIFO depth.
> 
> s/lager/larger

Applied, thanks. And I fixed up the typo when I did.

> > +       spi_irq = platform_get_irq(pdev, 0);
> > +       tspi->irq = spi_irq;
> > +       ret = request_threaded_irq(tspi->irq, tegra_spi_isr,
> > +                       tegra_spi_isr_thread, IRQF_ONESHOT,
> > +                       dev_name(&pdev->dev), tspi);
> 
> Can we use devm_request_threaded_irq instead? to save some code.

I don't have any quams about applying it as-is. That can be done as a
follow on patch.

g.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/