linux-kernel - Re: [PATCH RFT] pinctrl: single: Fix build error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 4 Mar 2013 17:18:19 +0800
From:	Axel Lin <axel.lin@...ics.com>
To:	Haojian Zhuang <haojian.zhuang@...aro.org>
Cc:	Linus Walleij <linus.walleij@...aro.org>,
	Tony Lindgren <tony@...mide.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFT] pinctrl: single: Fix build error

2013/3/4 Haojian Zhuang <haojian.zhuang@...aro.org>:
> On 4 March 2013 13:47, Axel Lin <axel.lin@...ics.com> wrote:
>> If pcs->is_pinconf is false, it means does not support pinconf.
>> If pcs->is_pinconf is true, is_generic flag is always true.
>>
>> This patch fixes below build error:
>>
>>   CC [M]  drivers/pinctrl/pinctrl-single.o
>> drivers/pinctrl/pinctrl-single.c: In function 'pcs_probe':
>> drivers/pinctrl/pinctrl-single.c:1441:3: error: assignment of member 'is_generic' in read-only object
>> make[2]: *** [drivers/pinctrl/pinctrl-single.o] Error 1
>> make[1]: *** [drivers/pinctrl] Error 2
>> make: *** [drivers] Error 2
>>
>> Signed-off-by: Axel Lin <axel.lin@...ics.com>
>> ---
>>  drivers/pinctrl/pinctrl-single.c |    6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
>> index 4cdcf85..e35dabd 100644
>> --- a/drivers/pinctrl/pinctrl-single.c
>> +++ b/drivers/pinctrl/pinctrl-single.c
>> @@ -734,6 +734,7 @@ static const struct pinconf_ops pcs_pinconf_ops = {
>>         .pin_config_dbg_show = pcs_pinconf_dbg_show,
>>         .pin_config_group_dbg_show = pcs_pinconf_group_dbg_show,
>>         .pin_config_config_dbg_show = pcs_pinconf_config_dbg_show,
>> +       .is_generic = true,
>
> There's two cases for is_generic. Your fix only make thing worse.

AFAICT, in current code ( linux-next 20130304, before applying this patch):
if match->data is false, pcs->is_pinconf is also false which means
pinconf isn't supported.

In the case pcs->is_pinconf is true, is_generic actually is *always*
true in current code.

>
> By the way, I already sent a patch to fix it.
Good to know that.
Can you point me the link to your patch?

Axel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/