linux-kernel - Re: [PATCH -v3 16/23] drivers/net: rename random32() to prandom

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 4 Mar 2013 14:37:01 +0100
From:	"Arend van Spriel" <arend@...adcom.com>
To:	"Akinobu Mita" <akinobu.mita@...il.com>
cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	"David S. Miller" <davem@...emloft.net>,
	"Michael Chan" <mchan@...adcom.com>,
	"Thomas Sailer" <t.sailer@...mni.ethz.ch>,
	"Jean-Paul Roubelat" <jpr@...bb.org>,
	"Bing Zhao" <bzhao@...vell.com>,
	"Brett Rudley" <brudley@...adcom.com>,
	"Franky (Zhenhui) Lin" <frankyl@...adcom.com>,
	"Hante Meuleman" <meuleman@...adcom.com>,
	brcm80211-dev-list@...adcom.com, netdev@...r.kernel.org,
	linux-hams@...r.kernel.org, linux-wireless@...r.kernel.org
Subject: Re: [PATCH -v3 16/23] drivers/net: rename random32() to
 prandom_u32()

On 03/04/13 13:58, Akinobu Mita wrote:
> Use more preferable function name which implies using a pseudo-random
> number generator.
>
> Signed-off-by: Akinobu Mita<akinobu.mita@...il.com>
> Acked-by: Thomas Sailer<t.sailer@...mni.ethz.ch>
> Acked-by: Bing Zhao<bzhao@...vell.com>  [mwifiex]
> Cc: "David S. Miller"<davem@...emloft.net>
> Cc: Michael Chan<mchan@...adcom.com>
> Cc: Thomas Sailer<t.sailer@...mni.ethz.ch>
> Cc: Jean-Paul Roubelat<jpr@...bb.org>
> Cc: Bing Zhao<bzhao@...vell.com>
> Cc: Brett Rudley<brudley@...adcom.com>
> Cc: Arend van Spriel<arend@...adcom.com>
> Cc: "Franky (Zhenhui) Lin"<frankyl@...adcom.com>
> Cc: Hante Meuleman<meuleman@...adcom.com>
> Cc: brcm80211-dev-list@...adcom.com
> Cc: netdev@...r.kernel.org
> Cc: linux-hams@...r.kernel.org
> Cc: linux-wireless@...r.kernel.org
> ---
> * Changes from v2
> - add Acked-by: line
> - add rename for brcm80211
>
>   drivers/net/ethernet/broadcom/cnic.c          | 4 ++--
>   drivers/net/hamradio/baycom_epp.c             | 2 +-
>   drivers/net/hamradio/hdlcdrv.c                | 2 +-
>   drivers/net/hamradio/yam.c                    | 2 +-
>   drivers/net/wireless/brcm80211/brcmfmac/p2p.c | 2 +-
>   drivers/net/wireless/mwifiex/cfg80211.c       | 4 ++--
>   6 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/net/wireless/brcm80211/brcmfmac/p2p.c b/drivers/net/wireless/brcm80211/brcmfmac/p2p.c
> index 4166e64..bca31a8 100644
> --- a/drivers/net/wireless/brcm80211/brcmfmac/p2p.c
> +++ b/drivers/net/wireless/brcm80211/brcmfmac/p2p.c
> @@ -1118,7 +1118,7 @@ static void brcmf_p2p_afx_handler(struct work_struct *work)
>   	if (afx_hdl->is_listen&&  afx_hdl->my_listen_chan)
>   		/* 100ms ~ 300ms */
>   		err = brcmf_p2p_discover_listen(p2p, afx_hdl->my_listen_chan,
> -						100 * (1 + (random32() % 3)));
> +					100 * (1 + (prandom_u32() % 3)));

Seems like indentation is wrong now. Please retain the alignment.

Regards,
Arend

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/