linux-kernel - Re: [ 34/77] xen/blkback: Dont trust the handle from the frontend.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130304024528.GA9385@kroah.com>
Date:	Mon, 4 Mar 2013 10:45:28 +0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Paul Bolle <pebolle@...cali.nl>
Cc:	Ben Hutchings <ben@...adent.org.uk>, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org, Jan Beulich <jbeulich@...e.com>,
	Ian Campbell <ian.campbell@...rix.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
Subject: Re: [ 34/77] xen/blkback: Dont trust the handle from the frontend.

On Sun, Mar 03, 2013 at 11:20:02AM +0100, Paul Bolle wrote:
> On Sat, 2013-03-02 at 23:10 +0000, Ben Hutchings wrote:
> > On Sat, 2013-03-02 at 23:35 +0100, Paul Bolle wrote:
> > > 1) So if xen_vbd_translate() fails, it can return before setting
> > > preq.dev. That makes the call of pr_debug() use an uninitialized value,
> > > doesn't it?
> > 
> > Oh yes, so it's a completely valid warning in this case!
> 
> Thanks.
> 
> Perhaps Konrad, Jan, Or Ian can tell whether the patch still needs to go
> in stable as is, because the problem it fixes is more severe than the
> problem it apparently creates. Maybe a mainline fix is needed before
> this can go in, or perhaps even a stable specific fix (if context
> changes are to blame).

I've left it in, as-is.  If this is a problem, please fix it in Linus's
tree, and then I'll be glad to accept the same fix here in the stable
kernel releases as well.  Just be sure to let me know if that happens.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/