linux-kernel - Re: [PATCH][v3] xhci: correctly enable interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1303041234460.1750-100000@iolanthe.rowland.org>
Date:	Mon, 4 Mar 2013 12:36:11 -0500 (EST)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
cc:	Thomas Renninger <trenn@...e.de>, Hannes Reinecke <hare@...e.de>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Oliver Neukum <oneukum@...e.de>,
	Yinghai Lu <yinghai@...nel.org>,
	Frederik Himpe <fhimpe@....ac.be>,
	David Haerdeman <david@...deman.nu>
Subject: Re: [PATCH][v3] xhci: correctly enable interrupts

On Mon, 4 Mar 2013, Sergei Shtylyov wrote:

> > @@ -371,6 +371,7 @@ static int xhci_try_enable_msi(struct usb_hcd *hcd)
> >   		return -EINVAL;
> >   	}
> >
> > + legacy_irq:
> >    
> 
>     Labels shouldn't be indented by a space (unless the existing coding 
> style has them indented already, of course).
> Although that might be a rule dropped by checkpatch.pl already -- it 
> doesn't complain.

Indeed, there's a definite advantage to putting a space before a label:  
The diff program doesn't get confused into thinking the label is the
start of a new function.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/