linux-kernel - Re: [PATCH 05/11] zcache: Make the debug code use pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1362421733.1965.11.camel@joe-AO722>
Date:	Mon, 04 Mar 2013 10:28:53 -0800
From:	Joe Perches <joe@...ches.com>
To:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
Cc:	linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org,
	devel@...verdev.osuosl.org, dan.magenheimer@...cle.com
Subject: Re: [PATCH 05/11] zcache: Make the debug code use pr_debug

On Mon, 2013-03-04 at 13:18 -0500, Konrad Rzeszutek Wilk wrote:
> as if you are debugging this driver you would be using 'debug'
> on the command line anyhow - and this would dump the debug
> data on the proper loglevel.

Please add
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
before any #includes and remove all the "zcache: "
prefixes from the pr_<level> uses.


> +	pr_debug("zcache: obj_count=%zd\n", zcache_obj_count);

just pr_debug("obj_count=%zd\n", zcache_obj_count);

etc.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/