linux-kernel - Re: [tpmdd-devel] [PATCH v2] tpm: Add support for new Infineon I2C TPM (SLB 9645 TT 1.2 I2C)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20130304185952.GA24196@obsidianresearch.com>
Date:	Mon, 4 Mar 2013 11:59:52 -0700
From:	Jason Gunthorpe <jgunthorpe@...idianresearch.com>
To:	Kent Yoder <key@...ux.vnet.ibm.com>
Cc:	Peter Huewe <peter.huewe@...ineon.com>,
	tpmdd-devel@...ts.sourceforge.net,
	linux-security-module@...r.kernel.org, shpedoikal@...il.com,
	linux-kernel@...r.kernel.org
Subject: Re: [tpmdd-devel] [PATCH v2] tpm: Add support for new Infineon I2C
 TPM (SLB 9645 TT 1.2 I2C)

On Mon, Mar 04, 2013 at 11:41:04AM -0600, Kent Yoder wrote:
> >  	.id_table = tpm_tis_i2c_table,
> >  	.probe = tpm_tis_i2c_probe,
> >  	.remove = tpm_tis_i2c_remove,
> > @@ -703,11 +759,12 @@ static struct i2c_driver tpm_tis_i2c_driver = {
> >  		   .name = "tpm_i2c_infineon",
> >  		   .owner = THIS_MODULE,
> >  		   .pm = &tpm_tis_i2c_ops,
> > +		   .of_match_table = of_match_ptr(tpm_tis_i2c_of_match),
> 
>   Please put this line inside an ifdef CONFIG_OF, since of_match_ptr
> lives in there.

The OF stuff is designed to hide the CONFIG_OF from using code, 
of_match_ptr(x) expends to NULL when CONFIG_OF is not set.

It is optional to include the MATCH_TABLE bit in a CONFI_OF #ifdef,
lots of places don't.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/