linux-kernel - Re: [PATCH] md: dm-verity: Fix to avoid a deadlock in dm-bufio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKwO_5GwN8PCtK6tM=KWvZMJHb357O+Bh3TpF3k3vB_0x_FtpQ@mail.gmail.com>
Date:	Mon, 4 Mar 2013 13:23:54 -0800
From:	Paul Taysom <taysom@...gle.com>
To:	Paul Taysom <taysom@...omium.org>, agk@...hat.com,
	dm-devel@...hat.com, neilb@...e.de, linux-raid@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Mandeep Singh Baines <msb@...omium.org>,
	Mikulas Patocka <mpatocka@...hat.com>,
	Olof Johansson <olofj@...omium.org>
Subject: Re: [PATCH] md: dm-verity: Fix to avoid a deadlock in dm-bufio

On Mon, Mar 4, 2013 at 9:42 AM, Alasdair G Kergon <agk@...hat.com> wrote:
> On Mon, Mar 04, 2013 at 08:45:48AM -0800, Paul Taysom wrote:
>> @@ -449,8 +468,14 @@ static void verity_prefetch_io(struct dm_verity *v, struct dm_verity_io *io)
>>                               hash_block_end = v->hash_blocks - 1;
>>               }
>>  no_prefetch_cluster:
>> -             dm_bufio_prefetch(v->bufio, hash_block_start,
>> -                               hash_block_end - hash_block_start + 1);
>> +             vw = kmalloc(sizeof(*vw), GFP_KERNEL);
>
> kmalloc?  mempool? ...
>
> Alasdair
>
The use of mempool would be a separate patch that would have to be
measured for performance impact.
-Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/