| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1362432489-6325-1-git-send-email-sebastian@breakpoint.cc> Date: Mon, 4 Mar 2013 22:28:09 +0100 From: Sebastian Andrzej Siewior <sebastian@...akpoint.cc> To: linux-usb@...r.kernel.org Cc: Felipe Balbi <balbi@...com>, linux-kernel@...r.kernel.org, Sebastian Andrzej Siewior <sebastian@...akpoint.cc>, Fengguang Wu <fengguang.wu@...el.com> Subject: [PATCH] usb/gadget: initialize gadget functions helper befor functions & gadgets Fengguang Wu run into a kernel ops after he complied dummy_hcd and g_cdc into the kernel. The problem was that u_serial was used by g_cdc before u_serial was initialized. In the module case eveything is initialized in the correct order but if we compile it into the kernel we rely on Makefile order which I did wrong and now I correct this. Cc: Fengguang Wu <fengguang.wu@...el.com> Signed-off-by: Sebastian Andrzej Siewior <sebastian@...akpoint.cc> --- I kinda assumed that this was already fixed (i.e. a patch like this was sent) but it seems not to be that case. drivers/usb/gadget/Makefile | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/usb/gadget/Makefile b/drivers/usb/gadget/Makefile index 97a13c3..1ded3d4 100644 --- a/drivers/usb/gadget/Makefile +++ b/drivers/usb/gadget/Makefile @@ -35,6 +35,12 @@ mv_udc-y := mv_udc_core.o obj-$(CONFIG_USB_FUSB300) += fusb300_udc.o obj-$(CONFIG_USB_MV_U3D) += mv_u3d_core.o +# USB Functions +obj-$(CONFIG_USB_U_SERIAL) += u_serial.o +obj-$(CONFIG_USB_F_ACM) += f_acm.o +f_ss_lb-y := f_loopback.o f_sourcesink.o +obj-$(CONFIG_USB_F_SS_LB) += f_ss_lb.o + # # USB gadget drivers # @@ -74,9 +80,3 @@ obj-$(CONFIG_USB_G_WEBCAM) += g_webcam.o obj-$(CONFIG_USB_G_NCM) += g_ncm.o obj-$(CONFIG_USB_G_ACM_MS) += g_acm_ms.o obj-$(CONFIG_USB_GADGET_TARGET) += tcm_usb_gadget.o - -# USB Functions -obj-$(CONFIG_USB_F_ACM) += f_acm.o -f_ss_lb-y := f_loopback.o f_sourcesink.o -obj-$(CONFIG_USB_F_SS_LB) += f_ss_lb.o -obj-$(CONFIG_USB_U_SERIAL) += u_serial.o -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists