linux-kernel - Re: [PATCH RESEND 1/3] e1000e: fix pci-device enable-counter balance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1362447219.2183.3.camel@jtkirshe-mobl>
Date:	Mon, 04 Mar 2013 17:33:39 -0800
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Konstantin Khlebnikov <khlebnikov@...nvz.org>
Cc:	linux-kernel@...r.kernel.org, e1000-devel@...ts.sourceforge.net,
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	Bruce Allan <bruce.w.allan@...el.com>
Subject: Re: [PATCH  RESEND 1/3] e1000e: fix pci-device enable-counter
 balance

On Mon, 2013-02-25 at 09:19 +0400, Konstantin Khlebnikov wrote:
> This patch removes redundant and unbalanced pci_disable_device() from
> __e1000_shutdown(). pci_clear_master() is enough, device can go into
> suspended state with elevated enable_cnt.
> 
> Bug was introduced in commit 23606cf5d1192c2b17912cb2ef6e62f9b11de133
> ("e1000e / PCI / PM: Add basic runtime PM support (rev. 4)") in
> v2.6.35
> 
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@...nvz.org>
> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> Cc: e1000-devel@...ts.sourceforge.net
> Cc: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> Cc: Bruce Allan <bruce.w.allan@...el.com>
> ---
>  drivers/net/ethernet/intel/e1000e/netdev.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-) 

I have added the patch to my queue of e1000e patches.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)