linux-kernel - Re: [PATCH] USB: storage: fix Huawei mode switching regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4661149.JOvxeICSJy@linux-5eaq.site>
Date:	Tue, 05 Mar 2013 09:32:32 +0100
From:	Oliver Neukum <oneukum@...e.de>
To:	Josua Dietze <digidietze@...isberghof.de>
Cc:	Bjørn Mork <bjorn@...k.no>,
	Matthew Dharm <mdharm-usb@...-eyed-alien.net>,
	Ben Hutchings <ben@...adent.org.uk>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Fangxiaozhi (Franko)" <fangxiaozhi@...wei.com>, zihan@...wei.com,
	Lin.Lei@...wei.com, Greg KH <gregkh@...uxfoundation.org>,
	"Yili (Neil)" <neil.yi@...wei.com>,
	"Wangyuhua (Roger, Credit)" <wangyuhua@...wei.com>,
	Huqiao <huqiao36@...wei.com>, Felipe Balbi <balbi@...com>,
	Sebastian Andrzej Siewior <sebastian@...akpoint.cc>,
	stable <stable@...r.kernel.org>
Subject: Re: [PATCH] USB: storage: fix Huawei mode switching regression

On Monday 04 March 2013 23:28:47 Josua Dietze wrote:
> > I guess the real problem will be verifying that all of the entries can
> > go away. This type of hardware tends to get old very fast, but there is
> > always someone having a really ancient device.
> 
> I will check this and add any missing USB IDs to usb_modeswitch, but I can't shake the feeling that not all Huawei entries in "unusual_devs.h" did actually materialize as devices ...
> 
> Anyway, as Bjørn said, putting that initialization into the storage driver takes away quite some possibilities to handle these modems in a flexible way.

But it adds the ability to handle loss of power in the suspend case
cleanly. As long as the switch only makes additional devices appear,
doing it in kernel space is the nicer approach.

	Regards
		Oliver

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/