linux-kernel - Re: [PATCH 04/10] dmatest: move dmatest_channels and nr_channels to dmatest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKohpomECZjXcaM-n64vfq+DMc9_G2aqa5ShfJ4j+_wVaeBrRQ@mail.gmail.com>
Date:	Tue, 5 Mar 2013 17:12:26 +0800
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:	linux-kernel@...r.kernel.org, Vinod Koul <vinod.koul@...el.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 04/10] dmatest: move dmatest_channels and nr_channels to dmatest_info

On 4 March 2013 17:09, Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
> We don't need to have them global and later we would like to protect access to
> them as well.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  drivers/dma/dmatest.c | 29 ++++++++++++++++-------------
>  1 file changed, 16 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
> index 7f9e3cc..475a21a 100644
> --- a/drivers/dma/dmatest.c
> +++ b/drivers/dma/dmatest.c
> @@ -109,6 +109,7 @@ struct dmatest_chan {
>   * @timeout:           transfer timeout in msec, -1 for infinite timeout
>   */
>  struct dmatest_info {
> +       /* Test parameters */
>         unsigned int    buf_size;
>         char            channel[20];
>         char            device[20];
> @@ -118,17 +119,14 @@ struct dmatest_info {
>         unsigned int    xor_sources;
>         unsigned int    pq_sources;
>         int             timeout;
> +
> +       /* Internal state */
> +       struct list_head        channels;
> +       unsigned int            nr_channels;
>  };

Acked-by: Viresh Kumar <viresh.kumar@...aro.org>

What about merging this patch with the patch which added this structure.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/