linux-kernel - Re: [PATCH] cpufreq: ARM big LITTLE: Add generic cpufreq driver and its DT glue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 5 Mar 2013 10:52:51 +0000
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Viresh Kumar <viresh.kumar@...aro.org>
Cc:	rjw@...k.pl, Steve.Bannister@....com, linux-pm@...r.kernel.org,
	Sudeep KarkadaNagesha <sudeep.karkadanagesha@....com>,
	Liviu.Dudau@....com, linux-kernel@...r.kernel.org,
	cpufreq@...r.kernel.org, robin.randhawa@....com,
	linux-arm-kernel@...ts.infradead.org, mark.hambleton@...adcom.com,
	linaro-kernel@...ts.linaro.org, charles.garcia-tobin@....com
Subject: Re: [PATCH] cpufreq: ARM big LITTLE: Add generic cpufreq driver
	and its DT glue

On Tue, Mar 05, 2013 at 12:52:41PM +0800, Viresh Kumar wrote:
> +static void put_cluster_clk_and_freq_table(u32 cluster)
> +{
> +	if (!atomic_dec_return(&cluster_usage[cluster])) {
> +		clk_put(clk[cluster]);
> +		clk[cluster] = NULL;

What's the point in setting the clk to NULL?

> +static int get_cluster_clk_and_freq_table(u32 cluster)
> +{
> +	char name[9] = "cluster";
> +	int count;
> +
> +	if (atomic_inc_return(&cluster_usage[cluster]) != 1)
> +		return 0;
> +
> +	freq_table[cluster] = arm_bL_ops->get_freq_tbl(cluster, &count);
> +	if (!freq_table[cluster])
> +		goto atomic_dec;
> +
> +	name[7] = cluster + '0';
> +	clk[cluster] = clk_get(NULL, name);
> +	if (!IS_ERR_OR_NULL(clk[cluster])) {

NAK.  Two reasons.

1. IS_ERR_OR_NULL.  You know about this, it's been on the list several
   times.

2. Maybe clk_get_sys() rather than clk_get() and use a sensible device
   name ("cpu-cluster.%u" maybe) rather than a connection name with a
   NULL device?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/