[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20130305145645.GG12123@arwen.pp.htv.fi>
Date: Tue, 5 Mar 2013 16:56:45 +0200
From: Felipe Balbi <balbi@...com>
To: Kishon Vijay Abraham I <kishon@...com>
CC: <grant.likely@...retlab.ca>, <rob.herring@...xeda.com>,
<rob@...dley.net>, <balbi@...com>, <gregkh@...uxfoundation.org>,
<s-guiriec@...com>, <gg@...mlogic.co.uk>, <sameo@...ux.intel.com>,
<broonie@...nsource.wolfsonmicro.com>, <ldewangan@...dia.com>,
<devicetree-discuss@...ts.ozlabs.org>, <linux-doc@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <linux-usb@...r.kernel.org>,
<linux-omap@...r.kernel.org>
Subject: Re: [PATCH 2/4] usb: dwc3: dwc3-omap: return -EPROBE_DEFER if probe
has not yet executed
On Tue, Mar 05, 2013 at 07:51:58PM +0530, Kishon Vijay Abraham I wrote:
> return -EPROBE_DEFER from dwc3_omap_mailbox in dwc3-omap.c, if the probe of
> dwc3-omap has not yet been executed or failed.
>
> Signed-off-by: Kishon Vijay Abraham I <kishon@...com>
> ---
> drivers/usb/dwc3/dwc3-omap.c | 7 +++++--
> include/linux/usb/dwc3-omap.h | 6 +++---
> 2 files changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c
> index 19c6e72..9428f4e 100644
> --- a/drivers/usb/dwc3/dwc3-omap.c
> +++ b/drivers/usb/dwc3/dwc3-omap.c
> @@ -138,11 +138,14 @@ static inline void dwc3_omap_writel(void __iomem *base, u32 offset, u32 value)
> writel(value, base + offset);
> }
>
> -void dwc3_omap_mailbox(enum omap_dwc3_vbus_id_status status)
> +int dwc3_omap_mailbox(enum omap_dwc3_vbus_id_status status)
> {
> u32 val;
> struct dwc3_omap *omap = _omap;
>
> + if (!omap)
> + return -EPROBE_DEFER;
> +
> switch (status) {
> case OMAP_DWC3_ID_GROUND:
> dev_dbg(omap->dev, "ID GND\n");
> @@ -185,7 +188,7 @@ void dwc3_omap_mailbox(enum omap_dwc3_vbus_id_status status)
> dev_dbg(omap->dev, "ID float\n");
> }
>
> - return;
> + return IRQ_HANDLED;
IRQ_HANDLED ????
--
balbi
Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)
Powered by blists - more mailing lists