linux-kernel - Re: [PATCH 3/4] USB: Palmas OTG Transceiver Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <513621CA.5010906@wwwdotorg.org>
Date:	Tue, 05 Mar 2013 09:48:10 -0700
From:	Stephen Warren <swarren@...dotorg.org>
To:	Kishon Vijay Abraham I <kishon@...com>
CC:	grant.likely@...retlab.ca, rob.herring@...xeda.com,
	rob@...dley.net, balbi@...com, gregkh@...uxfoundation.org,
	s-guiriec@...com, gg@...mlogic.co.uk, sameo@...ux.intel.com,
	broonie@...nsource.wolfsonmicro.com, ldewangan@...dia.com,
	devicetree-discuss@...ts.ozlabs.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
	linux-omap@...r.kernel.org
Subject: Re: [PATCH 3/4] USB: Palmas OTG Transceiver Driver

On 03/05/2013 07:21 AM, Kishon Vijay Abraham I wrote:
> From: Graeme Gregory <gg@...mlogic.co.uk>
> 
> This is the driver for the OTG transceiver built into the Palmas chip. It
> handles the various USB OTG events that can be generated by cable

> diff --git a/Documentation/devicetree/bindings/usb/twlxxxx-usb.txt b/Documentation/devicetree/bindings/usb/twlxxxx-usb.txt

> +palmas-usb {
> +	compatible = "ti,palmas-usb";

The example should probably demonstrate best DT practices, and include a
specific chip name in the compatible value too. In other words,
something like:

compatible = "ti,twl12345-usb", "ti,palmas-usb";
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/