linux-kernel - Re: [PATCH] kexec: consolidate crash late initialization

Open Source and information security mailing list archives

Message-ID: <20130305023206.GL16128@verge.net.au>
Date:	Tue, 5 Mar 2013 11:32:06 +0900
From:	Simon Horman <horms@...ge.net.au>
To:	Vladimir Davydov <vdavydov@...allels.com>
Cc:	Eric Biederman <ebiederm@...ssion.com>, kexec@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kexec: consolidate crash late initialization

On Wed, May 30, 2012 at 02:05:09PM +0400, Vladimir Davydov wrote:
> Use one module_init() instead of two.

I'm not sure I understand the motivation for this change.

> ---
>  kernel/kexec.c |    9 +++++++--
>  1 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/kexec.c b/kernel/kexec.c
> index 4e2e472..c3341cb 100644
> --- a/kernel/kexec.c
> +++ b/kernel/kexec.c
> @@ -1240,7 +1240,6 @@ static int __init crash_notes_memory_init(void)
>  	}
>  	return 0;
>  }
> -module_init(crash_notes_memory_init)
>  
>  
>  /*
> @@ -1520,7 +1519,13 @@ static int __init crash_save_vmcoreinfo_init(void)
>  	return 0;
>  }
>  
> -module_init(crash_save_vmcoreinfo_init)
> +static int __init crash_init(void)
> +{
> +	crash_notes_memory_init();
> +	crash_save_vmcoreinfo_init();
> +	return 0;
> +}
> +module_init(crash_init)
>  
>  /*
>   * Move into place and start executing a preloaded standalone
> -- 
> 1.7.1
> 
> 
> _______________________________________________
> kexec mailing list
> kexec@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives