linux-kernel - Re: [PATCH] thinkpad-acpi: fix potential suspend blocking issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201303052018.52320.maciej.rutecki@gmail.com>
Date:	Tue, 5 Mar 2013 20:18:52 +0100
From:	Maciej Rutecki <maciej.rutecki@...il.com>
To:	Mandeep Singh Baines <msb@...omium.org>
Cc:	linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org,
	ibm-acpi@....eng.br, ibm-acpi-devel@...ts.sourceforge.net,
	platform-driver-x86@...r.kernel.org, Aaron Lu <aaron.lu@...el.com>,
	Henrique de Moraes Holschuh <hmh@....eng.br>,
	Tejun Heo <tj@...nel.org>, Oleg Nesterov <oleg@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] thinkpad-acpi: fix potential suspend blocking issue

On wtorek, 5 marca 2013 o 18:34:43 Mandeep Singh Baines wrote:
> Fixes the following lockdep error:
> 
> [ BUG: ktpacpi_nvramd/446 still has locks held! ]
> 
> hotkey_kthread() calls set_freezable() after acquiring the
> hotkey_kthread_mutex(). set_freezable() calls try_to_freeze().
> This could block suspend if we were to freeze at this point
> and another task were to block on the mutex, potentially via
> writing to one of the sysfs attrs. This race is unlikely but
> can be easily fixed by moving the set_freezable() call.
> 
> Reported-by: Maciej Rutecki <maciej.rutecki@...il.com>
> Signed-off-by: Mandeep Singh Baines <msb@...omium.org>
> CC: Aaron Lu <aaron.lu@...el.com>
> CC: Henrique de Moraes Holschuh <hmh@....eng.br>
> CC: Tejun Heo <tj@...nel.org>
> CC: Oleg Nesterov <oleg@...hat.com>
> CC: Andrew Morton <akpm@...ux-foundation.org>
Tested-by: Maciej Rutecki <maciej.rutecki@...il.com>

Patch fixes the problem. Thanks!

Regards

-- 
Maciej Rutecki
http://www.mrutecki.pl
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/