linux-kernel - Re: [PATCH 6/7] tidspbridge: convert to idr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130305213703.GA10826@kroah.com>
Date:	Wed, 6 Mar 2013 05:37:03 +0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Tejun Heo <tj@...nel.org>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	bfields@...ldses.org, jackm@....mellanox.co.il,
	ogerlitz@...lanox.com, roland@...estorage.com,
	dan.magenheimer@...cle.com, vjaquez@...lia.com,
	rene.sapiens@...com, x0095078@...com, omar.ramirez@...com
Subject: Re: [PATCH 6/7] tidspbridge: convert to idr_alloc()

On Tue, Mar 05, 2013 at 12:02:51PM -0800, Tejun Heo wrote:
> idr_get_new*() and friends are about to be deprecated.  Convert to the
> new idr_alloc() interface.
> 
> There are some peculiarities and possible bugs in the converted
> functions.  This patch preserves those.
> 
> * drv_insert_node_res_element() returns -ENOMEM on alloc failure,
>   -EFAULT if id space is exhausted.  -EFAULT is at best misleading.
> 
> * drv_proc_insert_strm_res_element() is even weirder.  It returns
>   -EFAULT if kzalloc() fails, -ENOMEM if idr preloading fails and
>   -EPERM if id space is exhausted.  What's going on here?
> 
> * drv_proc_insert_strm_res_element() doesn't free *pstrm_res after
>   failure.
> 
> Only compile tested.
> 
> Signed-off-by: Tejun Heo <tj@...nel.org>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Víctor Manuel Jáquez Leal <vjaquez@...lia.com>
> Cc: Rene Sapiens <rene.sapiens@...com>
> Cc: Armando Uribe <x0095078@...com>
> Cc: Omar Ramirez Luna <omar.ramirez@...com>
> ---
>  drivers/staging/tidspbridge/rmgr/drv.c | 70 +++++++++++++---------------------
>  1 file changed, 26 insertions(+), 44 deletions(-)

Acked-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/