linux-kernel - Re: [PATCH 1/1] arch/x86/smpboot.c: Fix GCC Warning (unused variable)!

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 5 Mar 2013 23:02:09 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	"Raphael S.Carvalho" <raphael.scarv@...il.com>
cc:	Ingo Molnar <mingo@...hat.com>, "H. Peter Anvin" <hpa@...or.com>,
	x86@...nel.org, Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Jarkko Sakkinen <jarkko.sakkinen@...el.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] arch/x86/smpboot.c: Fix GCC Warning (unused
 variable)!

On Tue, 5 Mar 2013, Raphael S.Carvalho wrote:

> GCC complained about the unused variable c, thus I'm sending
> this patch in order to calm it down.
> I compiled the file and everything seems be ok!

What is your patch solving? How about removing the line completely?
And how about providing a changelog which makes sense ?

Thanks,

	tglx
 
> Signed-off-by: Raphael S.Carvalho <raphael.scarv@...il.com>
> ---
>  arch/x86/kernel/smpboot.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
> index a6ceaed..77a5616 100644
> --- a/arch/x86/kernel/smpboot.c
> +++ b/arch/x86/kernel/smpboot.c
> @@ -1367,7 +1367,7 @@ static inline void mwait_play_dead(void)
>  	unsigned int highest_subcstate = 0;
>  	int i;
>  	void *mwait_ptr;
> -	struct cpuinfo_x86 *c = __this_cpu_ptr(&cpu_info);
> +	__this_cpu_ptr(&cpu_info);
>  
>  	if (!this_cpu_has(X86_FEATURE_MWAIT))
>  		return;
> -- 
> 1.7.2.5
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/