[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20130305030623.GM16362@localhost.localdomain>
Date: Tue, 5 Mar 2013 11:06:23 +0800
From: Hu Tao <hutao@...fujitsu.com>
To: Paolo Bonzini <pbonzini@...hat.com>
Cc: kvm list <kvm@...r.kernel.org>, qemu-devel <qemu-devel@...gnu.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"Daniel P. Berrange" <berrange@...hat.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
Jan Kiszka <jan.kiszka@...mens.com>,
Gleb Natapov <gleb@...hat.com>,
Blue Swirl <blauwirbel@...il.com>,
Eric Blake <eblake@...hat.com>,
Andrew Jones <drjones@...hat.com>,
Marcelo Tosatti <mtosatti@...hat.com>,
Sasha Levin <levinsasha928@...il.com>,
Luiz Capitulino <lcapitulino@...hat.com>,
Anthony Liguori <aliguori@...ibm.com>,
Markus Armbruster <armbru@...hat.com>,
Stefan Hajnoczi <stefanha@...hat.com>,
Juan Quintela <quintela@...hat.com>,
Orit Wasserman <owasserm@...hat.com>,
Kevin Wolf <kwolf@...hat.com>,
Wen Congyang <wency@...fujitsu.com>,
"Michael S. Tsirkin" <mst@...hat.com>,
Alexander Graf <agraf@...e.de>,
Alex Williamson <alex.williamson@...hat.com>,
Peter Maydell <peter.maydell@...aro.org>
Subject: Re: [PATCH v13 2/8] start vm after resetting it
On Mon, Mar 04, 2013 at 10:32:17AM +0100, Paolo Bonzini wrote:
> Il 28/02/2013 13:13, Hu Tao ha scritto:
> > From: Wen Congyang <wency@...fujitsu.com>
> >
> > The guest should run after resetting it, but it does not run if its
> > old state is RUN_STATE_INTERNAL_ERROR or RUN_STATE_PAUSED.
> >
> > We don't set runstate to RUN_STATE_PAUSED when resetting the guest,
> > so the runstate will be changed from RUN_STATE_INTERNAL_ERROR or
> > RUN_STATE_PAUSED to RUN_STATE_RUNNING(not RUN_STATE_PAUSED).
>
> This is also debatable. In particular, restarting an INTERNAL_ERROR
> guest makes it harder to inspect the state at the time of the failure.
>
> INTERNAL_ERROR should never happen, let's separate this patch too.
Sure.
>
> Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists