linux-kernel - Re: [PATCH] ioatdma: allow all channels to have irq coalescing support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <84A937D219C2B44EB8EA44831ACA1E49171E519C@PRN-MBX02-3.TheFacebook.com>
Date:	Tue, 5 Mar 2013 22:30:01 +0000
From:	Dan Williams <djbw@...com>
To:	Dave Jiang <dave.jiang@...el.com>
CC:	"vinod.koul@...el.com" <vinod.koul@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ioatdma: allow all channels to have irq coalescing
 support



On 2/26/13 8:20 AM, "Dave Jiang" <dave.jiang@...el.com> wrote:

>Looks like only the RAID channels are allowed to have irq coalescing
>support
>in the existing code. Fixing that. The ioat3 cleanup code can handle
>memcpy
>ops anyways
>
>Signed-off-by: Dave Jiang <dave.jiang@...el.com>
>---
> drivers/dma/ioat/dma_v3.c |   12 +++---------
> 1 file changed, 3 insertions(+), 9 deletions(-)
>
>diff --git a/drivers/dma/ioat/dma_v3.c b/drivers/dma/ioat/dma_v3.c
>index 47588dc..368a184 100644
>--- a/drivers/dma/ioat/dma_v3.c
>+++ b/drivers/dma/ioat/dma_v3.c
>@@ -1268,15 +1268,9 @@ int __devinit ioat3_dma_probe(struct
>ioatdma_device *device, int dca)
> 	}
> 
> 
>-	if (is_raid_device) {
>-		dma->device_tx_status = ioat3_tx_status;
>-		device->cleanup_fn = ioat3_cleanup_event;
>-		device->timer_fn = ioat3_timer_event;
>-	} else {
>-		dma->device_tx_status = ioat_dma_tx_status;
>-		device->cleanup_fn = ioat2_cleanup_event;
>-		device->timer_fn = ioat2_timer_event;
>-	}
>+	dma->device_tx_status = ioat3_tx_status;
>+	device->cleanup_fn = ioat3_cleanup_event;
>+	device->timer_fn = ioat3_timer_event;
> 
> 	#ifdef CONFIG_ASYNC_TX_DISABLE_PQ_VAL_DMA
> 	dma_cap_clear(DMA_PQ_VAL, dma->cap_mask);

Acked-by: Dan Williams <djbw@...com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/