linux-kernel - Re: [PATCH v2 4/4] ipc: sem: do not hold ipc lock more than necessary

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51367B88.7000908@redhat.com>
Date:	Tue, 05 Mar 2013 18:11:04 -0500
From:	Rik van Riel <riel@...hat.com>
To:	Davidlohr Bueso <davidlohr.bueso@...com>
CC:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Emmanuel Benisty <benisty.e@...il.com>,
	"Vinod, Chegu" <chegu_vinod@...com>,
	"Low, Jason" <jason.low2@...com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	"H. Peter Anvin" <hpa@...or.com>,
	Andrew Morton <akpm@...ux-foundation.org>, aquini@...hat.com,
	Michel Lespinasse <walken@...gle.com>,
	Ingo Molnar <mingo@...nel.org>,
	Larry Woodman <lwoodman@...hat.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH v2 4/4] ipc: sem: do not hold ipc lock more than necessary

On 03/05/2013 04:36 AM, Davidlohr Bueso wrote:

> @@ -888,27 +924,34 @@ static int semctl_main(struct ipc_namespace *ns, int semid, int semnum,
>   {
>   	struct sem_array *sma;
>   	struct sem* curr;
> -	int err;
> +	int err, nsems;
>   	ushort fast_sem_io[SEMMSL_FAST];
>   	ushort* sem_io = fast_sem_io;
> -	int nsems;
>   	struct list_head tasks;
>
> -	sma = sem_lock_check(ns, semid);
> -	if (IS_ERR(sma))
> +	INIT_LIST_HEAD(&tasks);
> +
> +	rcu_read_lock();
> +	sma = sem_obtain_object_check(ns, semid);
> +	if (IS_ERR(sma)) {
> +		rcu_read_lock();

I assume this should be an rcu_read_unlock? :)

>   		return PTR_ERR(sma);
> +	}


-- 
All rights reversed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/