linux-kernel - Re: [PATCH] net/wireless/brcm80211: remove PCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKocOOOJRpaq-e=XX584e1JQDYq_N4q8rka0otZBWbdvzdLyuA@mail.gmail.com>
Date:	Mon, 4 Mar 2013 21:08:16 -0700
From:	Shuah Khan <shuahkhan@...il.com>
To:	Larry Finger <Larry.Finger@...inger.net>
Cc:	shuah.khan@...com, brudley@...adcom.com, arend@...adcom.com,
	frankyl@...adcom.com, linville@...driver.com,
	seth.forshee@...onical.com, pieterpg@...adcom.com,
	linux-wireless@...r.kernel.org, brcm80211-dev-list@...adcom.com,
	netdev@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net/wireless/brcm80211: remove PCI_BUS define from defs.h
 to fix warnings

On Mon, Mar 4, 2013 at 6:28 PM, Larry Finger <Larry.Finger@...inger.net> wrote:
> On 03/04/2013 07:02 PM, Shuah Khan wrote:
>>
>> PCI_BUS defined in defs.h results in warnings from all brcm80211 source
>> files
>> including defs.h. This define is not used in brcm80211. Removing this
>> define
>> fixes the warning.
>>
>> In file included from
>> drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c:35:0:
>> drivers/net/wireless/brcm80211/include/defs.h:23:0: warning: "PCI_BUS"
>> redefined [enabled by default]
>> include/uapi/linux/pci.h:36:0: note: this is the location of the previous
>> definition
>>    CC [M]  drivers/net/wireless/b43legacy/dma.o
>>    CC [M]  drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.o
>>    CC [M]  drivers/net/wireless/b43legacy/pio.o
>> In file included from
>> drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c:29:0:
>> drivers/net/wireless/brcm80211/include/defs.h:23:0: warning: "PCI_BUS"
>> redefined [enabled by default]
>> include/uapi/linux/pci.h:36:0: note: this is the location of the previous
>> definition
>> In file included from
>> drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c:29:0:
>> drivers/net/wireless/brcm80211/include/defs.h:23:0: warning: "PCI_BUS"
>> redefined [enabled by default]
>> include/uapi/linux/pci.h:36:0: note: this is the location of the previous
>> definition
>
>
> Strange, I do not see PCI_BUS defined anywhere in the include/ branch in
> either 3.8 or 3.9. In addition, I don't get these warnings. What is
> different in your system?
>
> Larry

I am sorry. Please ignore this patch. I had a old commit for a change
I was working on
and I thought I undid the changes. My apologies for the noise.

-- Shuah
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/