linux-kernel - Re: [Devel] [PATCH] nfsd: check client tracker initialization result

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5136DFBE.3090505@parallels.com>
Date:	Wed, 6 Mar 2013 10:18:38 +0400
From:	Stanislav Kinsbursky <skinsbursky@...allels.com>
To:	"J. Bruce Fields" <bfields@...ldses.org>
CC:	<linux-nfs@...r.kernel.org>, <Trond.Myklebust@...app.com>,
	<linux-kernel@...r.kernel.org>, <devel@...nvz.org>
Subject: Re: [Devel] [PATCH] nfsd: check client tracker initialization result

06.03.2013 09:06, Stanislav Kinsbursky пишет:
> 06.03.2013 01:20, J. Bruce Fields пишет:
>> On Thu, Feb 28, 2013 at 03:09:59PM +0300, Stanislav Kinsbursky wrote:
>>> Function nfsd4_client_tracking_init() can return error.
>>
>> Before, I think that we the nfsd4_client_* functions just became no-ops
>> in this case.  With the result that no client records get written, and
>> so clients are unable to reclaim on the next boot.
>>
>> Which is annoying, but possibly not as annoying as your server
>> completely refusing to start.
>>
>> It's arguably more helpful in the long run to fail immediately when we
>> recognize reboot recovery isn't going to work.  But in practice this may
>> mean people that never knew they had a problem suddenly have servers
>> that don't start at all.
>>
>> So I'm inclined to be more forgiving and leave this as it is.  But maybe
>> something like a warning printk would be appropriate.
>>
>
> Ok then.
> I'll add the warning anf convert the function to be "void" rather then "int".
> Thanks!
>

We already have a warning.
So, probably all we need is just to change a prototype to make it less confusing.
Is it ok?

-- 
Best regards,
Stanislav Kinsbursky
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/