linux-kernel - Re: [PATCH] gpio: viperboard: Remove duplicate code to set gpio->gpiob

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201303061138.21776.poeschel@lemonage.de>
Date:	Wed, 6 Mar 2013 11:38:21 +0100
From:	Lars Poeschel <poeschel@...onage.de>
To:	Axel Lin <axel.lin@...ics.com>
Cc:	Grant Likely <grant.likely@...retlab.ca>,
	Linus Walleij <linus.walleij@...aro.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpio: viperboard: Remove duplicate code to set gpio->gpiob_val

On Tuesday 05 March 2013 at 13:21:56, Axel Lin wrote:
> Set it once is enough, and it's done in vprbrd_gpiob_set() which is called
> by vprbrd_gpiob_direction_output().
> 
> Signed-off-by: Axel Lin <axel.lin@...ics.com>

Thank you!

Tested-and-Acked-by: Lars Poeschel <poeschel@...onage.de>

> ---
>  drivers/gpio/gpio-viperboard.c |    4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-viperboard.c
> b/drivers/gpio/gpio-viperboard.c index 59d7239..095ab14 100644
> --- a/drivers/gpio/gpio-viperboard.c
> +++ b/drivers/gpio/gpio-viperboard.c
> @@ -380,10 +380,6 @@ static int vprbrd_gpiob_direction_output(struct
> gpio_chip *chip, struct vprbrd *vb = gpio->vb;
> 
>  	gpio->gpiob_out |= (1 << offset);
> -	if (value)
> -		gpio->gpiob_val |= (1 << offset);
> -	else
> -		gpio->gpiob_val &= ~(1 << offset);
> 
>  	mutex_lock(&vb->lock);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/