linux-kernel - Re: [PATCH] efivarfs: fix abnormal GUID in variable name by using strcpy to replace null with dash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1362577086.15011.57.camel@mfleming-mobl1.ger.corp.intel.com>
Date:	Wed, 06 Mar 2013 13:38:06 +0000
From:	Matt Fleming <matt@...sole-pimps.org>
To:	Frederic Crozat <fcrozat@...e.com>
Cc:	joeyli <jlee@...e.com>, linux-efi@...r.kernel.org,
	linux-kernel@...r.kernel.org, Michael Schroeder <mls@...e.com>,
	Josh Boyer <jwboyer@...hat.com>,
	Peter Jones <pjones@...hat.com>,
	Matthew Garrett <mjg59@...f.ucam.org>
Subject: Re: [PATCH] efivarfs: fix abnormal GUID in variable name by using
 strcpy to replace null with dash

On Wed, 2013-03-06 at 14:30 +0100, Frederic Crozat wrote:
> Le mercredi 06 mars 2013 à 12:36 +0000, Matt Fleming a écrit :
> > On Wed, 2013-03-06 at 12:58 +0100, Frederic Crozat wrote:
> > > Le mercredi 06 mars 2013 à 11:19 +0000, Matt Fleming a écrit :
> > > 
> > > > Also, which machine did you see this behaviour on?
> > > 
> > > HP z220 desktop, System BIOS K51 v 1.54
> > > 
> > > this issue is only the "Secure Boot" related variables, which make me
> > > think HP incorrectly created them in their latest firmware (where they
> > > added Windows 8 support).
> > 
> > Are you saying that the behaviour regarding VariableNameSize changes
> > depending on which variable is returned?
> >
> > Mercy.....
>  
> Well, I only get the error message for some variables (8), not all of
> them.
> 
> It was quite visible on unpatched kernel, with ls
> -d /sys/firmware/efi/vars. 
> 
> ls -d /sys/firmware/efi/vars/*8be4d* | grep -v -- -8be returns
> /sys/firmware/efi/vars/dbxDefault-pport8be4df61-93ca-11d2-aa0d-00e098032b8c
> /sys/firmware/efi/vars/KEKDefault-pport8be4df61-93ca-11d2-aa0d-00e098032b8c
> /sys/firmware/efi/vars/SecureBoot-pport8be4df61-93ca-11d2-aa0d-00e098032b8c
> /sys/firmware/efi/vars/SetupMode-Information8be4df61-93ca-11d2-aa0d-00e098032b8c
> /sys/firmware/efi/vars/SignatureSupport-pport8be4df61-93ca-11d2-aa0d-00e098032b8c
> /sys/firmware/efi/vars/VendorKeys-pport8be4df61-93ca-11d2-aa0d-00e098032b8c
> 
> All other variable names were fine.

Interesting. Thanks.

-- 
Matt Fleming, Intel Open Source Technology Center

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/