linux-kernel - Re: Byteorder conditional compilation problems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 6 Mar 2013 09:37:35 -0800
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	David Howells <dhowells@...hat.com>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	Joakim.Tjernlund@...nsmode.se,
	Andrew Morton <akpm@...ux-foundation.org>,
	"linux-arch@...r.kernel.org" <linux-arch@...r.kernel.org>,
	Arnd Bergmann <arnd@...db.de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: Byteorder conditional compilation problems

On Wed, Mar 6, 2013 at 8:43 AM, David Howells <dhowells@...hat.com> wrote:
>
> Scripting a change from "defined(__XXX_ENDIAN)" to "(__XXX_ENDIAN==__BYTEORDER)"
> should be easy to script.

How about we just make the rule be that we shouldn't test __xyz_ENDIAN
at all, and instead always use CONFIG_xyz_ENDIAN, which isn't
ambiguous. And then have the exporter of the uapi header files just
sed-script that into __xyz_ENDIAN == __BYTEORDER.

The whole __xyz_ENDIAN == __BYTE_ORDER syntax is moronic, and the
standard under BSD seems to be single-underscore "_BYTE_ORDER", while
glibc uses double underscore __BYTE_ORDER. The whole thing is a
f*cking mess, and I really don't want to get the idiotic mess into the
kernel any more than I have to.

In fact, I'd prefer to let it just be. Changing it in the kernel to
the idiotic and non-standard user mode format is pointless. Just fix
up the (few) entries in the uapi header files.

                  Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/