linux-kernel - Re: [PATCH net-next] vmxnet3: prevent div-by-zero panic when ring resizing uninitialized dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130306.153841.784919874486534382.davem@davemloft.net>
Date:	Wed, 06 Mar 2013 15:38:41 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	bhavesh@...are.com
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	pv-drivers@...are.com, sbhatewara@...are.com
Subject: Re: [PATCH net-next] vmxnet3: prevent div-by-zero panic when ring
 resizing uninitialized dev

From: Bhavesh Davda <bhavesh@...are.com>
Date: Wed,  6 Mar 2013 09:46:24 -0800

> Linux is free to call ethtool ops as soon as a netdev exists when probe
> finishes. However, we only allocate vmxnet3 tx/rx queues and initialize the
> rx_buf_per_pkt field in struct vmxnet3_adapter when the interface is
> opened (UP).
> 
> Signed-off-by: Bhavesh Davda <bhavesh@...are.com>
> Signed-off-by: Shreyas N Bhatewara <sbhatewara@...are.com>
> ---
>  drivers/net/vmxnet3/vmxnet3_drv.c     |    3 ++-
>  drivers/net/vmxnet3/vmxnet3_ethtool.c |    6 ++++++
>  drivers/net/vmxnet3/vmxnet3_int.h     |    4 ++--
>  3 files changed, 10 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c
> index 4aad350..bfc5898 100644
> --- a/drivers/net/vmxnet3/vmxnet3_drv.c
> +++ b/drivers/net/vmxnet3/vmxnet3_drv.c
> @@ -2922,7 +2922,7 @@ vmxnet3_probe_device(struct pci_dev *pdev,
>  				    (int)num_online_cpus());
>  	else
>  #endif
> -		num_rx_queues = 1;
> +	num_rx_queues = 1;

Why are you un-indenting this else branch?  Please don't do that.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/