linux-kernel - Re: Revert commit 5dcd14ecd4 - breaks EFI boot with SLES11 elilo.efi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <414399ca-2000-4120-88fb-af1d203990eb@email.android.com>
Date:	Wed, 06 Mar 2013 12:43:39 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Josh Boyer <jwboyer@...il.com>
CC:	Yinghai Lu <yinghai@...nel.org>, Robin Holt <holt@....com>,
	linux-kernel@...r.kernel.org, pjones@...hat.com
Subject: Re: Revert commit 5dcd14ecd4 - breaks EFI boot with SLES11 elilo.efi

Yeah.  I'll queue it up today and send to Linus in the next batch.

Josh Boyer <jwboyer@...il.com> wrote:

>On Wed, Mar 6, 2013 at 12:37 PM, H. Peter Anvin <hpa@...or.com> wrote:
>> On 03/06/2013 09:36 AM, Josh Boyer wrote:
>>>
>>> Something like this?
>>>
>>> Index: linux-2.6/arch/x86/include/asm/bootparam_utils.h
>>> ===================================================================
>>> --- linux-2.6.orig/arch/x86/include/asm/bootparam_utils.h
>>> +++ linux-2.6/arch/x86/include/asm/bootparam_utils.h
>>> @@ -20,8 +20,11 @@ static void sanitize_boot_params(struct
>>>       if (boot_params->sentinel) {
>>>               /*fields in boot_params are not valid, clear them */
>>>               memset(&boot_params->olpc_ofw_header, 0,
>>> -                    (char *)&boot_params->alt_mem_k -
>>> +                    (char *)&boot_params->efi_info -
>>>                       (char *)&boot_params->olpc_ofw_header);
>>>               memset(&boot_params->kbd_status, 0,
>>>                      (char *)&boot_params->hdr -
>>>                      (char *)&boot_params->kbd_status);
>>>
>>> I can try that in a bit.
>>>
>>
>> Right.
>
>OK.  Doing that on top of 3.9-rc1 results in me having a booting
>machine
>again.  I'd suggest we get that into upstream quick-ish.
>
>josh

-- 
Sent from my mobile phone. Please excuse brevity and lack of formatting.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/