linux-kernel - Re: [PATCH] hugetlb: fix sparse warning for hugetlb_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEnQRZAiiJqHcEHoS+=ZMAHdQwu9yYc28or1Di7h4R7PRn6iEg@mail.gmail.com>
Date:	Thu, 7 Mar 2013 14:55:25 +0200
From:	Daniel Baluta <daniel.baluta@...il.com>
To:	Claudiu Ghioc <claudiughioc@...il.com>, trivial@...nel.org,
	jkosina@...e.cz
Cc:	akpm@...ux-foundation.org, mhocko@...e.cz,
	aneesh.kumar@...ux.vnet.ibm.com, dhillf@...il.com,
	kamezawa.hiroyu@...fujitsu.com, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org,
	Claudiu Ghioc <claudiu.ghioc@...il.com>
Subject: Re: [PATCH] hugetlb: fix sparse warning for hugetlb_register_node

On Mon, Mar 4, 2013 at 12:46 PM, Claudiu Ghioc <claudiughioc@...il.com> wrote:
> Removed the following sparse warnings:
> *  mm/hugetlb.c:1764:6: warning: symbol
>     'hugetlb_unregister_node' was not declared.
>     Should it be static?
> *   mm/hugetlb.c:1808:6: warning: symbol
>     'hugetlb_register_node' was not declared.
>     Should it be static?
>
> Signed-off-by: Claudiu Ghioc <claudiu.ghioc@...il.com>
> ---
>  mm/hugetlb.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index 0a0be33..c65a8a5 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -1761,7 +1761,7 @@ static struct hstate *kobj_to_node_hstate(struct kobject *kobj, int *nidp)
>   * Unregister hstate attributes from a single node device.
>   * No-op if no hstate attributes attached.
>   */
> -void hugetlb_unregister_node(struct node *node)
> +static void hugetlb_unregister_node(struct node *node)
>  {
>         struct hstate *h;
>         struct node_hstate *nhs = &node_hstates[node->dev.id];
> @@ -1805,7 +1805,7 @@ static void hugetlb_unregister_all_nodes(void)
>   * Register hstate attributes for a single node device.
>   * No-op if attributes already registered.
>   */
> -void hugetlb_register_node(struct node *node)
> +static void hugetlb_register_node(struct node *node)
>  {
>         struct hstate *h;
>         struct node_hstate *nhs = &node_hstates[node->dev.id];
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

Hi Jiri,

Can you pick this up via trivial tree?

thanks,
Daniel.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/