| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <5138ACFE.30701@canonical.com> Date: Thu, 07 Mar 2013 16:06:38 +0100 From: Maarten Lankhorst <maarten.lankhorst@...onical.com> To: Matt Fleming <matt.fleming@...el.com> CC: Matthew Garrett <mjg59@...f.ucam.org>, linux-efi@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>, Seth Forshee <seth.forshee@...onical.com> Subject: [PATCH] efivarfs: loosen restriction on valid names Commit da27a2438 (efivarfs: guid part of filenames are case-insensitive) fails to boot, because the kernel creates files in the form of dump-type-x-y-z-GUID. Since the kernel already created files in this form, these type of files obviously exist, so the right course of action is to relax the restriction in efivarfs_valid_name. Signed-off-by: Maarten Lankhorst <maarten.lankhorst@...onical.com> Cc: stable@...r.kernel.org [3.8] --- diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c index 8bcb595..3ee1882 100644 --- a/drivers/firmware/efivars.c +++ b/drivers/firmware/efivars.c @@ -921,8 +921,8 @@ static bool efivarfs_valid_name(const char *str, int len) if (len < GUID_LEN + 2) return false; - /* GUID should be right after the first '-' */ - if (s - 1 != strchr(str, '-')) + /* GUID should be prefixed with - */ + if (s[-1] != '-') return false; /* -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists