linux-kernel - Re: + memblock-add-assertion-for-zero-allocation-alignment.patch added to -mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5137E779.5050904@zytor.com>
Date:	Wed, 06 Mar 2013 17:03:53 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Yinghai Lu <yinghai@...nel.org>
CC:	akpm@...ux-foundation.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	mm-commits@...r.kernel.org, Vineet.Gupta1@...opsys.com,
	liwanp@...ux.vnet.ibm.com, mingo@...nel.org, tj@...nel.org,
	vgupta@...opsys.com
Subject: Re: + memblock-add-assertion-for-zero-allocation-alignment.patch
 added to -mm tree

On 03/06/2013 04:07 PM, Yinghai Lu wrote:
>>
>>  mm/memblock.c |    3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff -puN mm/memblock.c~memblock-add-assertion-for-zero-allocation-alignment mm/memblock.c
>> --- a/mm/memblock.c~memblock-add-assertion-for-zero-allocation-alignment
>> +++ a/mm/memblock.c
>> @@ -771,6 +771,9 @@ static phys_addr_t __init memblock_alloc
>>  {
>>         phys_addr_t found;
>>
>> +       if (WARN_ON(!align))
>> +               align = __alignof__(long long);
>> +
>>         /* align @size to avoid excessive fragmentation on reserved array */
>>         size = round_up(size, align);
> 
> Hi, Peter,
> 
> Do you agree that we should check align in round_up()?
> 

Not in round_up(), that is used in way too many places.  Doing it in
memblock_alloc() might make sense.

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/