linux-kernel - Re: 8250.nr_uarts broken in 3.7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 7 Mar 2013 16:14:27 -0500
From:	Josh Boyer <jwboyer@...hat.com>
To:	Jiri Slaby <jslaby@...e.cz>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: 8250.nr_uarts broken in 3.7

On Thu, Mar 07, 2013 at 02:10:05PM -0500, Josh Boyer wrote:
> On Thu, Mar 07, 2013 at 08:07:23PM +0100, Jiri Slaby wrote:
> > On 03/07/2013 07:56 PM, Josh Boyer wrote:
> > > commit 835d844d1a28efba81d5aca7385e24c29d3a6db2
> > > Author: Sean Young <sean@...s.org>
> > > Date:   Fri Sep 7 19:06:23 2012 +0100
> > > 
> > >     8250_pnp: do pnp probe before legacy probe
> > > 
> > > but that is simply moving code around.
> > 
> > Hi, not quite. Does it still happen when you revert that one on the top
> > of 3.[789]*?
> 
> That was going to be my first attempt.  I'll let you know how it goes.

Yes, reverting just 835d844d1 on top of 3.7.0 fixes it.  I also see why
now.  That commit changed the module name from 8250 to 8250_core in the
makefile, so clearly 8250.nr_uarts = 16 isn't going to get parsed.
Adding 8250_core.nr_uarts = 16 seems to work fine.  This wasn't
immediately obvious because the whole thing is built-in and not a
module.  Thankfully, looking in /sys/modules/ still works and that
showed up pretty clearly.

So I guess this isn't really a break in functionality as much as it's a
driver rename.  Not sure if it's worth fixing in some form or not.

josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/