linux-kernel - Re: [PATCH] cpufreq: ARM big LITTLE: Add generic cpufreq driver and its DT glue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKohponduoxw8KoWtCzfYgthXGmi=8=ydR4dzQOy--PXcPFfWg@mail.gmail.com>
Date:	Thu, 7 Mar 2013 09:46:16 +0800
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	Harvey Harrison <harvey.harrison@...il.com>
Cc:	Russell King - ARM Linux <linux@....linux.org.uk>, rjw@...k.pl,
	Steve.Bannister@....com, linux-pm@...r.kernel.org,
	Sudeep KarkadaNagesha <sudeep.karkadanagesha@....com>,
	Liviu.Dudau@....com, linux-kernel@...r.kernel.org,
	cpufreq@...r.kernel.org, robin.randhawa@....com,
	linux-arm-kernel@...ts.infradead.org, mark.hambleton@...adcom.com,
	linaro-kernel@...ts.linaro.org, charles.garcia-tobin@....com
Subject: Re: [PATCH] cpufreq: ARM big LITTLE: Add generic cpufreq driver and
 its DT glue

On 7 March 2013 08:49, Harvey Harrison <harvey.harrison@...il.com> wrote:
> On Wed, Mar 6, 2013 at 4:32 PM, Viresh Kumar <viresh.kumar@...aro.org> wrote:
>
>>         clk[cluster] = clk_get_sys(name, NULL);
>> -       if (!IS_ERR(clk[cluster])) {
>> +       if (!IS_ERR_OR_NULL(clk[cluster])) {
>>                 pr_debug("%s: clk: %p & freq table: %p, cluster: %d\n",
>>                                 __func__, clk[cluster], freq_table[cluster],
>>                                 cluster);
>
>
> You seem pretty attached to IS_ERR_OR_NULL here.

Haha. Not really. I just wanted to get more logical conclusion out. Please check
the other mail (where i would reply to Russell), which might have more
discussion
around this.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/