| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20130307015800.GA2468@balto.lan> Date: Thu, 7 Mar 2013 09:58:00 +0800 From: Fabio Baltieri <fabio.baltieri@...aro.org> To: Felipe Balbi <balbi@...com> Cc: Linus Walleij <linus.walleij@...aro.org>, linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org Subject: Re: [PATCH 3/5] usb: musb: ux500: add otg notifier support On Wed, Mar 06, 2013 at 10:54:46AM +0200, Felipe Balbi wrote: > > > are you sure this is correct ? you're not doing anything in case of > > > vbus event. Shouldn't you make sure your vbus is off ? > > > > The implementation I'm taking as reference for this patches does not do > > anything on VBUS event and as I can see from commmit history, it has > > been based on the omap2430 one, that in turns used to just run phy_init > > - and that's not implemented. But... > > > > > What if your user uses a non-standard cable which has id-pin grounded > > > on both sides ? > > > > A cable with two micro/mini connectors with grounded IDs? Did you ever > > encountered such a thing? I guess a ux500_musb_set_vbus(musb, 0) would > > in fact, no... > > > not hurt in that case. > > right, just to be sure. Maybe I should fix omap2430 as well. I'll add it > to my TODO list. Fair enough, I'll send a v2 of this patch with the added vbus-off as soon as I manage to test it. Thanks, Fabio -- Fabio Baltieri -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists