linux-kernel - Re: [PATCH] alarmtimer: add error prints when suspend failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130307231640.GE4280@kroah.com>
Date:	Fri, 8 Mar 2013 07:16:40 +0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Laxman Dewangan <ldewangan@...dia.com>
Cc:	john.stultz@...aro.org, toddpoynor@...gle.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] alarmtimer: add error prints when suspend failed

On Fri, Mar 08, 2013 at 12:57:37AM +0530, Laxman Dewangan wrote:
> The alramtimer suspend failed when nearest alarm wakeup time is
> less than 2 sec or rtc timer can not start.
> 
> In suspend/resume stress testing, we found that sometimes alramtimer
> failed to suspend and hence it cancel the suspend ops. Add error prints
> in suspend failure to provide more info when failure occurs to help
> debugging.
> 
> Signed-off-by: Laxman Dewangan <ldewangan@...dia.com>
> ---
>  kernel/time/alarmtimer.c |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/kernel/time/alarmtimer.c b/kernel/time/alarmtimer.c
> index f11d83b..eed5646 100644
> --- a/kernel/time/alarmtimer.c
> +++ b/kernel/time/alarmtimer.c
> @@ -249,6 +249,8 @@ static int alarmtimer_suspend(struct device *dev)
>  
>  	if (ktime_to_ns(min) < 2 * NSEC_PER_SEC) {
>  		__pm_wakeup_event(ws, 2 * MSEC_PER_SEC);
> +		dev_err(dev,
> +			"Nearest alarm wakeup time < 2sec, avoiding suspend\n");

What can userspace now do with this information?  How often is this now
going to spam the syslog and cause confusion?

>  		return -EBUSY;
>  	}
>  
> @@ -260,8 +262,10 @@ static int alarmtimer_suspend(struct device *dev)
>  
>  	/* Set alarm, if in the past reject suspend briefly to handle */
>  	ret = rtc_timer_start(rtc, &rtctimer, now, ktime_set(0, 0));
> -	if (ret < 0)
> +	if (ret < 0) {
>  		__pm_wakeup_event(ws, MSEC_PER_SEC);
> +		dev_err(dev, "RTC timer start failed, %d\n", ret);

Same here, you aren't changing any code paths, just annoying people who
can't do anything about this.

As you want to do this for debugging, make them debugging level messages
please.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/