linux-kernel - Re: [PATCH v3 1/2] Input: atmel_mxt_ts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANLzEks+1DS8qUwbyVQU6WdyT2pKYKWYJGNOjyExR8dGG0AHng@mail.gmail.com>
Date:	Thu, 7 Mar 2013 22:57:19 -0800
From:	Benson Leung <bleung@...omium.org>
To:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Olof Johansson <olofj@...omium.org>,
	Yufeng Shen <miletus@...omium.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Matthew Garrett <matthew.garrett@...ula.com>,
	Henrik Rydberg <rydberg@...omail.se>,
	Daniel Kurtz <djkurtz@...omium.org>,
	Joonyoung Shim <jy0922.shim@...sung.com>, wfp5p@...ginia.edu,
	linux-input@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"platform-driver-x86@...r.kernel.org" 
	<platform-driver-x86@...r.kernel.org>
Cc:	Benson Leung <bleung@...omium.org>,
	David Miller <davem@...emloft.net>,
	Nick Dyer <nick.dyer@...ev.co.uk>
Subject: Re: [PATCH v3 1/2] Input: atmel_mxt_ts - Support for touchpad variant

On Thu, Mar 7, 2013 at 7:43 PM, Benson Leung <bleung@...omium.org> wrote:
> +static void mxt_input_button(struct mxt_data *data, struct mxt_message *message)
> +{
> +       struct device *dev = &data->client->dev;
Oops. I missed a warning: unused variable 'dev' here.

> +       struct input_dev *input = data->input_dev;
> +       bool button;
> +       int i;
> +
> +       /* Active-low switch */
> +       for (i = 0; i < MXT_NUM_GPIO; i++) {
> +               if (data->pdata->key_map[i] == KEY_RESERVED)
> +                       continue;
> +               button = !(message->message[0] & MXT_GPIO0_MASK << i);
> +               input_report_key(input, data->pdata->key_map[i], button);
> +       }
> +}
> +




--
Benson Leung
Software Engineer, Chrom* OS
bleung@...omium.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/