linux-kernel - Re: [PATCH 1/1 v5] pwm_bl: Add support for backlight enable regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130308072934.GC5772@avionic-0098.mockup.avionic-design.de>
Date:	Fri, 8 Mar 2013 08:29:34 +0100
From:	Thierry Reding <thierry.reding@...onic-design.de>
To:	Andrew Chew <achew@...dia.com>
Cc:	acourbot@...dia.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1 v5] pwm_bl: Add support for backlight enable regulator

On Thu, Mar 07, 2013 at 01:16:08PM -0800, Andrew Chew wrote:
> The backlight enable regulator is specified in the device tree node for
> backlight.
> 
> Signed-off-by: Andrew Chew <achew@...dia.com>

This looks good in general. I'd like to see Alex' comment addressed and
perhaps the commit message shouldn't be device tree specific, since the
same can be done with legacy board setup code. It would be nice if it'd
mention something about why the regulator is added.

Thierry

Content of type "application/pgp-signature" skipped