linux-kernel - Re: [PATCH 10/16] TTY: cleanup tty->hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 08 Mar 2013 15:46:10 +0100
From:	Jiri Slaby <jslaby@...e.cz>
To:	Peter Hurley <peter@...leysoftware.com>
CC:	Jiri Slaby <jirislaby@...il.com>, gregkh@...uxfoundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 10/16] TTY: cleanup tty->hw_stopped uses

On 03/08/2013 03:39 PM, Peter Hurley wrote:
> On Thu, 2013-03-07 at 13:12 +0100, Jiri Slaby wrote:
>> --- a/drivers/net/caif/caif_serial.c
>> +++ b/drivers/net/caif/caif_serial.c
>> @@ -88,7 +88,6 @@ static inline void update_tty_status(struct ser_device *ser)
>>  {
>>  	ser->tty_status =
>>  		ser->tty->stopped << 5 |
>> -		ser->tty->hw_stopped << 4 |
>>  		ser->tty->flow_stopped << 3 |
>>  		ser->tty->packet << 2 |
>>  		ser->tty->port->low_latency << 1 |
> 
> I would maybe leave this with a code comment instead.
> 
> 		ser->tty->hw_stopped << 4 |      /* hw_stopped is not used by tty layer */

Yeah, maybe...

>> @@ -4256,9 +4251,6 @@ static void seq_line_info(struct seq_file *m, struct e100_serial *info)
>>  		if (info->port.tty->stopped)
>>  			seq_printf(m, " stopped:%i",
>>  				   (int)info->port.tty->stopped);
>> -		if (info->port.tty->hw_stopped)
>> -			seq_printf(m, " hw_stopped:%i",
>> -				   (int)info->port.tty->hw_stopped);
> 
> User-space visible. Tool may expect this field.

I thought that on the first glance too. But look what does that whole
seq_printf depend on.

-- 
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/