linux-kernel - Re: [RFC PATCH 1/1] usb: f_rndis: Avoid to use ERROR macro if cdev can be null

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130308201639.GB14787@kroah.com>
Date:	Fri, 8 Mar 2013 12:16:39 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	oskar.andero@...ymobile.com, linux-kernel@...r.kernel.org,
	linux-usb@...r.kernel.org, Felipe Balbi <balbi@...com>,
	Truls Bengtsson <truls.bengtsson@...ymobile.com>,
	Radovan Lekanovic <radovan.lekanovic@...ymobile.com>
Subject: Re: [RFC PATCH 1/1] usb: f_rndis: Avoid to use ERROR macro if cdev
 can be null

On Fri, Mar 08, 2013 at 11:56:26PM +0400, Sergei Shtylyov wrote:
> Hello.
> 
> On 08-03-2013 16:53, oskar.andero@...ymobile.com wrote:
> 
> >From: Truls Bengtsson <truls.bengtsson@...ymobile.com>
> 
> >The udc_irq service runs the isr_tr_complete_handler which in turn
> >"nukes" the endpoints, including a call to rndis_response_complete,
> >if appropriate. If the rndis_msg_parser fails here, an error will
> >be printed using a dev_err call (through the ERROR() macro).
> 
> >However, if the usb cable was just disconnected the device (cdev)
> >might not be available and will be null. Since the dev_err macro will
> >dereference the cdev pointer we get a null pointer exception.
> 
> >Reviewed-by: Radovan Lekanovic <radovan.lekanovic@...ymobile.com>
> >Signed-off-by: Truls Bengtsson <truls.bengtsson@...ymobile.com>
> >Signed-off-by: Oskar Andero <oskar.andero@...ymobile.com>
> >---
> >  drivers/usb/gadget/f_rndis.c |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> >diff --git a/drivers/usb/gadget/f_rndis.c b/drivers/usb/gadget/f_rndis.c
> >index 71beeb8..41b5ebd 100644
> >--- a/drivers/usb/gadget/f_rndis.c
> >+++ b/drivers/usb/gadget/f_rndis.c
> >@@ -6,6 +6,7 @@
> >   * Copyright (C) 2008 Nokia Corporation
> >   * Copyright (C) 2009 Samsung Electronics
> >   *                    Author: Michal Nazarewicz (mina86@...a86.com)
> >+ * Copyright (C) 2013 Sony Mobile Communications AB.
> 
>    Your change seems too insignificant to add a copyright.

You are right, it legally is.  Truls, please consult your company's
lawyers if you have questions about this, you can not assert copyright
over a file for a 2 line change, that's not allowed at all in any
jurisdiction I know of.

Because of that, I can not accept this change, sorry.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/