linux-kernel - Re: [PATCH] misc/vmw_vmci: Add dependency on CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <513A4BC4.1040701@xenotime.net>
Date:	Fri, 08 Mar 2013 12:36:20 -0800
From:	Randy Dunlap <rdunlap@...otime.net>
To:	Guenter Roeck <linux@...ck-us.net>
CC:	linux-kernel@...r.kernel.org, Andy King <acking@...are.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Dmitry Torokhov <dtor@...are.com>
Subject: Re: [PATCH] misc/vmw_vmci: Add dependency on CONFIG_NET

On 02/27/13 11:41, Guenter Roeck wrote:
> Building the vmw_vmci driver with CONFIG_NET undefined results in:
> 
> drivers/built-in.o: In function `__qp_memcpy_from_queue.isra.13':
> vmci_queue_pair.c:(.text+0x1671a8): undefined reference to `memcpy_toiovec'
> drivers/built-in.o: In function `__qp_memcpy_to_queue.isra.14':
> vmci_queue_pair.c:(.text+0x167341): undefined reference to `memcpy_fromiovec'
> make[1]: [vmlinux] Error 1 (ignored)
> 
> since memcpy_toiovec and memcpy_fromiovec are defined in the networking code.
> Add the missing dependency.
> 
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>

Acked-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

> ---
>  drivers/misc/vmw_vmci/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/vmw_vmci/Kconfig b/drivers/misc/vmw_vmci/Kconfig
> index 39c2eca..ea98f7e 100644
> --- a/drivers/misc/vmw_vmci/Kconfig
> +++ b/drivers/misc/vmw_vmci/Kconfig
> @@ -4,7 +4,7 @@
>  
>  config VMWARE_VMCI
>  	tristate "VMware VMCI Driver"
> -	depends on X86 && PCI
> +	depends on X86 && PCI && NET
>  	help
>  	  This is VMware's Virtual Machine Communication Interface.  It enables
>  	  high-speed communication between host and guest in a virtual
> 


-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/