lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <1362846754.3137.9.camel@x61.thuisdomein>
Date:	Sat, 09 Mar 2013 17:32:34 +0100
From:	Paul Bolle <pebolle@...cali.nl>
To:	Samuel Ortiz <sameo@...ux.intel.com>
Cc:	linux-kernel@...r.kernel.org
Subject: [PATCH] mfd: drop "select PMIC_DA9055"

The Kconfig entry for DA9055 PMIC Support selects PMIC_DA9055. That was
probably inspired by the similar select statement in the entry for
DA9052/53 PMIC with I2C. But the DA9055 PMIC only comes in an I2C
variant and its driver doesn't need a separate Kconfig symbol for shared
code. In any case, this select can be dropped as PMIC_DA9055 doesn't
exist.

Signed-off-by: Paul Bolle <pebolle@...cali.nl>
---
0) Tested with "git grep" only.

1) Note that the DA9052 and DA9055 drivers all have code for module
support, but their Kconfig entries only allow them to be builtin. Can't
these entries be made tristate? If not, shouldn't the code for module
support be removed?

 drivers/mfd/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 671f5b1..cdff6dd 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -487,7 +487,6 @@ config MFD_DA9055
 	bool "Dialog Semiconductor DA9055 PMIC Support"
 	select REGMAP_I2C
 	select REGMAP_IRQ
-	select PMIC_DA9055
 	select MFD_CORE
 	depends on I2C=y && GENERIC_HARDIRQS
 	help
-- 
1.7.11.7

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ