linux-kernel - Re: [PATCH] fs: pstore: Replaced calls to kmalloc and memcpy with kmemdup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jLakegTD5KPmpJviWtRJ2UgRUX7v+q2+BrsGZknzOLA0Q@mail.gmail.com>
Date:	Sun, 10 Mar 2013 16:23:01 -0700
From:	Kees Cook <keescook@...omium.org>
To:	Alexandru Gheorghiu <gheorghiuandru@...il.com>
Cc:	Anton Vorontsov <cbouatmailru@...il.com>,
	Colin Cross <ccross@...roid.com>,
	Tony Luck <tony.luck@...el.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fs: pstore: Replaced calls to kmalloc and memcpy with kmemdup

On Sat, Mar 9, 2013 at 3:57 AM, Alexandru Gheorghiu
<gheorghiuandru@...il.com> wrote:
> Replaced calls to kmalloc and memcpy with a single call to kmemdup.
> This patch was found using coccicheck.
>
> Signed-off-by: Alexandru Gheorghiu <gheorghiuandru@...il.com>
> ---
>  fs/pstore/ram.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
> index 288f068..38babb3 100644
> --- a/fs/pstore/ram.c
> +++ b/fs/pstore/ram.c
> @@ -156,10 +156,9 @@ static ssize_t ramoops_pstore_read(u64 *id, enum pstore_type_id *type,
>         time->tv_nsec = 0;
>
>         size = persistent_ram_old_size(prz);
> -       *buf = kmalloc(size, GFP_KERNEL);
> +       *buf = kmemdup(persistent_ram_old(prz), size, GFP_KERNEL);
>         if (*buf == NULL)
>                 return -ENOMEM;
> -       memcpy(*buf, persistent_ram_old(prz), size);
>
>         return size;
>  }

Looks fine to me. Thanks!

Acked-by: Kees Cook <keescook@...omium.org>

-Kees

-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/