linux-kernel - Re: [PATCH 2/3 V2] intel_idle: Removing the redundant calculating for dev->state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <513D9F23.5050705@linaro.org>
Date:	Mon, 11 Mar 2013 10:08:51 +0100
From:	Daniel Lezcano <daniel.lezcano@...aro.org>
To:	Chuansheng Liu <chuansheng.liu@...el.com>
CC:	lenb@...nel.org, len.brown@...el.com, linux-pm@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3 V2] intel_idle: Removing the redundant calculating
 for dev->state_count

On 03/11/2013 11:44 AM, Chuansheng Liu wrote:
> 
> In function intel_idle_cpu_init() and intel_idle_cpuidle_driver_init(),
> they are having the same for(;;) loop to count the ->state_count.
> 
> Although intel_idle_cpu_init() can be called at runtime CPU HOTPLUG case,
> but max_cstate can not be changed at runtime.
> 
> So the dev->state_count should be == drv->state_count, in the function
> cpuidle_register_device() has done the initialization.
> 
> Here we can clean up these pieces of code.
> 
> Signed-off-by: liu chuansheng <chuansheng.liu@...el.com>
> ---

Acked-by: Daniel Lezcano <daniel.lezcano@...aro.org>




-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/