linux-kernel - Re: [PATCH 3/6] i2c: Ignore return value of i2c_del

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1363024331.2608.9.camel@bwh-desktop.uk.solarflarecom.com>
Date:	Mon, 11 Mar 2013 17:52:11 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Lars-Peter Clausen <lars@...afoo.de>
CC:	Wolfram Sang <wsa@...-dreams.de>, Ben Dooks <ben-linux@...ff.org>,
	<linux-i2c@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	Jean Delvare <khali@...ux-fr.org>,
	Guan Xuetao <gxt@...c.pku.edu.cn>,
	Mauro Carvalho Chehab <mchehab@...hat.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Alan Cox <alan@...ux.intel.com>,
	Nicolas Ferre <nicolas.ferre@...el.com>,
	Aaro Koskinen <aaro.koskinen@....fi>,
	Shawn Guo <shawn.guo@...aro.org>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Lars Poeschel <poeschel@...onage.de>
Subject: Re: [PATCH 3/6] i2c: Ignore return value of i2c_del_adapter()

On Sat, 2013-03-09 at 19:16 +0100, Lars-Peter Clausen wrote:
> i2c_del_adapter() always returns 0. So all checks testing whether it will be
> non zero will always evaluate to false and the conditional code is dead code.
> This patch updates all callers of i2c_del_mux_adapter() to ignore the return
> value and assume that it will always succeed (which it will). In a subsequent
> patch the return type of i2c_del_adapter() will be made void.
> 
> Cc: Jean Delvare <khali@...ux-fr.org>
> Cc: Guan Xuetao <gxt@...c.pku.edu.cn>
> Cc: Mauro Carvalho Chehab <mchehab@...hat.com>
> Cc: Ben Hutchings <bhutchings@...arflare.com>

Acked-by: Ben Hutchings <bhutchings@...arflare.com>
(for the sfc changes)

> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Alan Cox <alan@...ux.intel.com>
> Cc: Nicolas Ferre <nicolas.ferre@...el.com>
> Cc: Aaro Koskinen <aaro.koskinen@....fi>
> Cc: Marek Vasut <marex@...x.de> (commit_signer:11/20=55%)

You should probably remove that get_maintainer.pl annotation!

Ben.

> Cc: Shawn Guo <shawn.guo@...aro.org>
> Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> Cc: Lars Poeschel <poeschel@...onage.de>
> Signed-off-by: Lars-Peter Clausen <lars@...afoo.de>
[...]

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/