linux-kernel - SNB-PEBS errate in perf code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130311191507.GA31827@phenom.dumpdata.com>
Date:	Mon, 11 Mar 2013 15:15:07 -0400
From:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
To:	jun.nakajima@...el.com, eranian@...gle.com, a.p.zijlstra@...llo.nl,
	mingo@...nel.org, linux-kernel@...r.kernel.org
Subject: SNB-PEBS errate in perf code - omits stepping 2?

Hey,

I think quirk:

+static int intel_snb_pebs_broken(int cpu)
+{
+       u32 rev = UINT_MAX; /* default to broken for unknown models */
+
+       switch (cpu_data(cpu).x86_model) {
+       case 42: /* SNB */
+               rev = 0x28;
+               break;
+
+       case 45: /* SNB-EP */
+               switch (cpu_data(cpu).x86_mask) {
+               case 6: rev = 0x618; break;
+               case 7: rev = 0x70c; break;
+               }
+       }
+
+       return (cpu_data(cpu).microcode < rev);
+}
+


needs a bit of update? I've this CPU:

vendor_id       : GenuineIntel
cpu family      : 6
model           : 45
model name      : Genuine Intel(R) CPU  @ 2.30GHz
stepping        : 2
cpu MHz         : 2294.534
cache size      : 20480 KB
..
microcode       : 0x8000020c

and since the stepping is '2' and there are no 'default' case
in the switch statement, it ends up failing b/c it is asking
for revision UINT_MAX.

Is there a specific microcode errate version for this type
of CPU? Or am I a lucky recipient of an early development CPU?


Perhaps that check should also have this:

diff --git a/arch/x86/kernel/cpu/perf_event_intel.c b/arch/x86/kernel/cpu/perf_event_intel.c
index 529c893..287d43a 100644
--- a/arch/x86/kernel/cpu/perf_event_intel.c
+++ b/arch/x86/kernel/cpu/perf_event_intel.c
@@ -1845,6 +1845,9 @@ static int intel_snb_pebs_broken(int cpu)
 		case 7: rev = 0x70c; break;
 		}
 	}
+	if (rev == UINT_MAX)
+		pr_warn("Please contact Intel to update quirk as you have"
+			"an unknown CPU stepping: %d\n", cpu_data(cpu).x86_mask);
 
 	return (cpu_data(cpu).microcode < rev);
 }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/